gh-106581: Split CALL_PY_EXACT_ARGS into uops#107760
Merged
gvanrossum merged 20 commits intopython:mainfrom Aug 16, 2023
Merged
gh-106581: Split CALL_PY_EXACT_ARGS into uops#107760gvanrossum merged 20 commits intopython:mainfrom
CALL_PY_EXACT_ARGS into uops#107760gvanrossum merged 20 commits intopython:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only the first step for doing
CALLin Tier 2. The next step involves tracing into the called code object. After that we'll have to do the remainingCALLspecialization. Finally we'll have to tweak various things likeKW_NAMES, and possibly move theNULL(for method calls) above the callable (that's 107788). But those are things for future PRs.Note: this moves setting
frame->return_offsetdirectly in front ofDISPATCH_INLINED(), to make it easier to move it into_PUSH_FRAME.CALL's stack #107788_Py_EnterRecursivePy